Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement <gshadow.h> functions. #40

Merged
merged 2 commits into from
May 15, 2022
Merged

Implement <gshadow.h> functions. #40

merged 2 commits into from
May 15, 2022

Conversation

chronos-tachyon
Copy link
Contributor

  • Implement getsgent and friends
  • Replace fprint(FILE, "%s", STRING) with fputs(STRING, FILE)
  • Extend tests to cover gshadow
  • Improve Makefile to reduce busywork when running tests multiple times in a row
  • Use some Bourne shell safety features in scripts/gentestdata.sh

@google-cla
Copy link

google-cla bot commented Apr 1, 2022

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

For more information, open the CLA check for this pull request.

@jaqx0r
Copy link
Contributor

jaqx0r commented May 15, 2022

Nice, thanks!

@codecov-commenter
Copy link

Codecov Report

Merging #40 (a5cdb07) into main (17655db) will decrease coverage by 1.06%.
The diff coverage is 64.77%.

@@            Coverage Diff             @@
##             main      #40      +/-   ##
==========================================
- Coverage   71.03%   69.97%   -1.07%     
==========================================
  Files           2        2              
  Lines         328      403      +75     
  Branches       22       26       +4     
==========================================
+ Hits          233      282      +49     
- Misses         78      100      +22     
- Partials       17       21       +4
Impacted Files Coverage Δ
gen_getent.c 63.03% <58.49%> (-1.77%) ⬇️
lookup.c 74.78% <74.28%> (-0.09%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 64612f9...a5cdb07. Read the comment docs.

@jaqx0r jaqx0r merged commit 909d316 into google:main May 15, 2022
@chronos-tachyon chronos-tachyon deleted the chronos/gshadow branch June 9, 2022 22:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jaqx0r jaqx0r jaqx0r approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@chronos-tachyon @jaqx0r @codecov-commenter